You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 22 Next »

According to ISO/IEC 9899-1999,

There may be unnamed padding within a structure object, but not at its beginning.

This is often referred to as structure padding. Structure members are arranged in memory as they are declared in the program text. Padding may be added to the structure to ensure the structure is properly aligned in memory.

Non-Compliant Code Example

The example below, is inspired by Dowd, assumes that the size of struct buffer is equal to the sizeof(size_t) + (sizeof(char) * 50), which may be incorrect. The size of struct buffer may actually be a larger due to structure padding.

struct buffer {
    size_t size;
    char buffer[50];
};

...

void func(struct buffer *buf) {

  /* assuming sizeof(size_t) is 4, this equals 54 */
  struct buffer *buf_cpy = malloc((sizeof(size_t)+(sizeof(char)*50)));

  if (buf_cpy == NULL) {
    /* Handle malloc() error */
  }
  ...
 /* with padding, sizeof(struct buffer) may be greater than 54, causing in a small buffer overflow */
  memcpy(buf_cpy, buf, sizeof(struct buffer));
}

Compliant Solution

Structure padding should be accounted for when working with structures.

struct buffer {
    size_t size;
    char buffer[50];
};

...

void func(struct buffer *buf) {

  struct buffer *buf_cpy = malloc((sizeof(struct buffer));
  if (buf_cpy == NULL) {
    /* Handle malloc() error */
  }

  ...

  memcpy(buf_cpy, buf, sizeof(struct buffer));
}
  • No labels