FLP34-C. Ensure that floating point conversions are within range of the new type

If a floating point value is to be demoted to a floating point value of a smaller range and precision or to an integer type, or if an integer type is to be converted to a floating point type, it must be ensured that this value is representable by the new type.

Section 6.3.1.4 of C99 says [[ISO/IEC 9899:1999]]

When a finite value of real floating type is converted to an integer type other than _Bool, the fractional part is discarded (i.e., the value is truncated toward zero). If the value of the integral part cannot be represented by the integer type, the behavior is undefined.)

When a value of integer type is converted to a real floating type, if the value being converted can be represented exactly in the new type, it is unchanged. If the value being converted is in the range of values that can be represented but cannot be represented exactly, the result is either the nearest higher or nearest lower representable value, chosen in an implementation-defined manner. If the value being converted is outside the range of values that can be represented, the behavior is undefined.

And section 6.3.1.5 says [[ISO/IEC 9899:1999]]

When a double is demoted to float, a long double is demoted to double or float, or a value being represented in greater precision and range than required by its semantic type (see 6.3.1.8) is explicitly converted (including to its own type), if the value being converted can be represented exactly in the new type, it is unchanged. If the value being converted is in the range of values that can be represented but cannot be represented exactly, the result is either the nearest higher or nearest lower representable value, chosen in an implementation-defined manner. If the value being converted is outside the range of values that can be represented, the behavior is undefined.

Consequently, in implementations that do not allow for the representation of all numbers, conversions of too-small numbers (between zero and FLT_MIN) may result in undefined behavior.

This rule does not apply to demotions of floating point types on implementations that support signed infinity, such as IEEE 754, as all numbers are representable.

Noncompliant Code Example (int-float)

The following noncompliant code leads to undefined behavior if the integral part of f1 cannot be represented as an integer.

float f1;
int i1;

/* initializations */

i1 = f1; /* Undefined if the integral part of f1 > INT_MAX */

Compliant Solution (int-float)

This compliant solution assumes that the range of floating point values is greater than that of integers (this is the case in almost all implementations). Unfortunately, there is no safe way to inquire about this assumption in the code short of already knowing the implementation.

float f1;
int i1;

/* initializations */

if (f1 > (float) INT_MAX || f1 < (float) INT_MIN) {
  /* Handle Error */
} else {
  i1 = f1;
}

Noncompliant Code Example (demotions)

The following noncompliant code shows casts of values that may not be outside of the range of the demoted type.

long double ld;
double d1;
double d2;
float f1;
float f2;

/* initializations */

f1 = (float)d1;
f2 = (float)ld;
d2 = (double)ld;

As a result of these conversions, it is possible that d1 is outside the range of values that can be represented by a float or that ld is outside the range of values that can be represented as either a float or a double. If this is the case, the result is undefined.

Compliant Solution (demotions)

This compliant solution properly checks to see whether the values to be stored can be represented in the new type.

#include <float.h>

long double ld;
double d1;
double d2;
float f1;
float f2;

/* initializations */

if (d1 > FLT_MAX || d1 < -FLT_MAX) {
  	/* Handle error condition */
} else {
 	f1 = (float)d1;
}
if (ld > FLT_MAX || ld < -FLT_MAX) {
	/* Handle error condition */
} else {
	f2 = (float)ld;
}
if (ld > DBL_MAX || ld < -DBL_MAX) {
	/* Handle error condition */
} else {
	d2 = (double)ld;
}

Risk Analysis

Failing to check that a floating point value fits within a demoted type can result in a value too large to be represented by the new type, resulting in undefined behavior.

Automated Detection

Fortify SCA Version 5.0 with CERT C Rule Pack can detect violations of this rule.

Compass/ROSE can detect some violations of this rule. However, it does not flag implicit casts, only explicit ones.

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

[[ISO/IEC 9899:1999]] Section 6.3.1.4, "Real floating and integer," and Section 6.3.1.5, "Real floating types"
[[ISO/IEC PDTR 24772]] "FLC Numeric Conversion Errors"
[[IEEE 754]] IEEE 754-1985 Standard for Binary Floating-Point Arithmetic
[[MITRE 07]] CWE ID 681, "Incorrect Conversion between Numeric Types"

FLP33-C. Convert integers to floating point for floating point operations      05. Floating Point (FLP)       06. Arrays (ARR)