INT02-J. Do not assume a positive remainder when using the remainder operator

The operation of the remainder operator in Java is defined in the Java Language Specification [[JLS 05]], Section 15.17.3 "Remainder Operator %":

The remainder operation for operands that are integers after binary numeric promotion (§5.6.2) produces a result value such that (a/b)*b+(a%b) is equal to a. This identity holds even in the special case that the dividend is the negative integer of largest possible magnitude for its type and the divisor is -1 (the remainder is 0). It follows from this rule that the result of the remainder operation can be negative only if the dividend is negative, and can be positive only if the dividend is positive; moreover, the magnitude of the result is always less than the magnitude of the divisor.

Although clearly defined in the Java specification, the behavior of the remainder operator's equivalent is undefined in several early C implementations. Programmers who are unaware of this distinction might always expect a positive remainder and code accordingly. This can result in vulnerabilities.

The result of the remainder operator implies the following behavior:

5 % 3 produces 2
5 % (-3) produces 2
(-5) % 3 produces -2
(-5) % (-3) produces  -2

The result has the same sign as the dividend (the first operand in the expression).

Noncompliant Code Example

In this noncompliant code example, the integer hashKey references an element of the hash array. However, as the hash key is not guaranteed to be positive, the lookup function may fail, triggering a java.lang.ArrayIndexOutOfBoundsException on all negative inputs.

private int SIZE = 16;	
public int[] hash = new int[SIZE];
	
public int lookup(int hashKey) {
  return hash[hashKey % SIZE];
}

Compliant Solution

This compliant solution calls a method that returns a modulus that is always positive.

// method imod() gives non-negative result
private int SIZE = 16;
public int[] hash = new int[SIZE];

private int imod(int i, int j) {
  return (i < 0) ? ((-i) % j) : (i % j);
}
	
public int lookup(int hashKey) {
  return hash[imod(hashKey, size)];
}

Compliant Solution

Alternatively, an explicit range check must be performed on the numerator at every susceptible point as demonstrated in this compliant solution.

public int lookup(int hashKey) {
  if (hashKey < 0)
    return hash[(-hashKey) % size];
  return hash[hashKey % size];
}

Note that providing a well documented imod method is a better choice as it improves readability and makes it clear that its sole purpose is to return positive values when required and not to "fix" the unintuitive behavior of the remainder operator, as defined by the specification.

Risk Assessment

Assuming a positive remainder when using the remainder operator can result in incorrect computations.

Other Languages

This rule appears in the C Secure Coding Standard as INT10-C. Do not assume a positive remainder when using the % operator.

This rule appears in the C++ Secure Coding Standard as INT10-CPP. Do not assume a positive remainder when using the % operator,

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

[[JLS 05]] §15.17.3 Remainder Operators

INT01-J. Provide mechanisms to handle unsigned data when required      06. Integers (INT)      INT30-J. Range check before casting integers to narrower types